basic code. please give me some advice,thank you!